March 25th, 2002

bike
  • jnala

Checkfriends bug, Cmd-N, confirmation

1) If you have checkfriends turned on, and you lose network connectivity, iJournal wigs out. It beeps incessantly and pops up semi-infinite number of error dialogs. This is because the error handling in checkFriends: is broken; if sending the request to the server fails, myValue is nil at the end of the routine, and the timer for the next checkFriends: call gets set to nil seconds rather than 60 or something reasonable. I wrote a short patch to fix it so it won't wig out, but really, a silent background function like checkfriends shouldn't pop up a dialog if it fails. At most a status-line update is appropriate. So a slightly more involved patch should be written, IMHO.

2) In most Mac applications, Cmd-N opens a new something. In iJournal, it's natural for the user to hit Cmd-N to open a new post. And if it's what the user expects, then it ought to work. Cmd-N is currently unused and could easily be made an alternate binding for "Open Window".

3) The confirmation sheet is poorly worded. It says "the post was added to your LiveJournal". But if you're posting to a community, it wasn't added to your journal - it was posted to the community journal. I did a double-take when I first saw this, thinking maybe I'd forgotten to set which journal I was posting to. When the user is posting to a community, "The post was added to the foobar community journal." would be better wording.

4) However, IMHO the sheet should be removed altogether. It's intrusive and accomplishes nothing beyond forcing the user to click OK before doing something else. Simply unghosting the buttons and putting "Post successful" in the status line would be adequate user feedback, and it would make the UI cleaner and more usable.