Log in

No account? Create an account

Previous Entry | Next Entry

Edit Last Entry in community

I post to macosx. I decide I want to change the post. The Journal pulldown is still set to "macosx". I select "Edit Last Entry". It pulls up the last entry in alanj, while the Journal pulldown still says macosx. This is wrong. I change the text, hit submit, and get a server error. Bad.

I wrote a one-line patch which fixes this behavior. With it, Edit Last Entry will edit the last entry in whatever journal you've currently selected.


( 12 comments — Leave a comment )
Mar. 23rd, 2002 09:40 pm (UTC)
I already addressed this issue a few posts ago. There's also already a patch that greys out the "Journal" menu, because when you're editing an entry it's pointless anyway, you can't change the journal you posted an entry in at this point in time.
Mar. 23rd, 2002 09:43 pm (UTC)
Actually, I'm not sure if the patch clears the menu or not, other than disabling it, so nevermind.
Mar. 23rd, 2002 09:47 pm (UTC)
Graying out the pulldown is good UI - I noticed the change in the CVS version I was working with - but it doesn't address the problem I mentioned.
Mar. 23rd, 2002 09:59 pm (UTC)
I agree. A combination of editing the most recent entry in *any* journal, showing the correct journal in the "Journal" popup menu, and greying it out on edit, until there is a solution to the problem of switching journals for an entry at least, would probably be the best solution.

Sorry for the confusion. :)
Mar. 23rd, 2002 09:49 pm (UTC)
When was this added to getevents? When I did the original implementation I can't believe I would have missed that since I went through great pains to bitch about it when I ran into this in 1.0. Shame on me for not checking the mode pages recently... it looks like a few more things have been added.

Thanks for pointing this out. I'll remove the ghosting and replace it with the addition of usejournal.
Mar. 23rd, 2002 09:52 pm (UTC)
hmm, ok... this still wouldn't let you change which journal you post -to-. got it.

So I'll leave the ghosting out, and add this change. Thanks for the patch.
Mar. 23rd, 2002 09:55 pm (UTC)
Not being able to edit the last entry in any journal - which is fixed by usejournal - is a separate issue from not being able to move an existing post between journals - which may or may not be supported by the protocol, and if it's not, the ghosting is a good idea and should stay.
Mar. 23rd, 2002 10:08 pm (UTC)
There is another issue brought up by this...

If the last entry -isn't- from you, you still get it, but can't make any changes to it.

So there really needs to be a entry=-1&user=you in order for this to really be useful.

Someone needs to document this so people don't get bit by this thinking they can edit -their- last entry to the community.
Mar. 23rd, 2002 10:28 pm (UTC)
IMHO if sending an editentry request with user=alanj and usejournal=macosx ever returns a post by someone other than alanj, that's a bug in the server's implementation of the protocol.

IIRC logjam also displays the behavior you describe.
Mar. 23rd, 2002 11:41 pm (UTC)
Yes.. there are other obscure things... that's why I'm waiting to see what the new client protocol will look like.
Mar. 24th, 2002 06:19 pm (UTC)
I should have reviewed the patch a little better. Basically, the patch will -only- work on last entry for a shared journal, and prevents you from editing the last entry in your own journal. I'll add yet another work around for a livejournal protocol-specific issue.

I vaguely remember running into this early on, which is why I had it the way that it was, however it is important to at least -attempt- to be able to edit your last entry in a shared journal.

This needs to be a candidate in an updated protocol and should be brought up in lj_dev. Basically -1 needs to return the last entry posted by the user when usejournal is sent, rather than the last entry of the shared journal.
Mar. 24th, 2002 07:37 pm (UTC)
Mea culpa. I thought I'd tested that case. I fixed it - here's the revised patch.

Also, do you want to bring this particular protocol issue up in lj_dev, or should I? (I should go get my goathack setup working so I can contribute LJ patches for little things like this...)
( 12 comments — Leave a comment )


iJournal: Official LiveJournal Client for Mac OS X
iJournal Home

Latest Month

June 2011
Powered by LiveJournal.com
Designed by Lilia Ahner